qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] block: do not probe zero-sized disks


From: Paolo Bonzini
Subject: [Qemu-devel] [PATCH] block: do not probe zero-sized disks
Date: Thu, 10 Jan 2013 15:39:27 +0100

A blank CD or DVD is visible as a zero-sized disks.  Probing such
disks will lead to an EIO and a failure to start the VM.  Treating
them as raw is a better solution.

Signed-off-by: Paolo Bonzini <address@hidden>
---
 block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block.c b/block.c
index c05875f..b9da10e 100644
--- a/block.c
+++ b/block.c
@@ -532,7 +532,7 @@ static int find_image_format(const char *filename, 
BlockDriver **pdrv)
     }
 
     /* Return the raw BlockDriver * to scsi-generic devices or empty drives */
-    if (bs->sg || !bdrv_is_inserted(bs)) {
+    if (bs->sg || !bdrv_is_inserted(bs) || bdrv_getlength(bs) == 0) {
         bdrv_delete(bs);
         drv = bdrv_find_format("raw");
         if (!drv) {
-- 
1.8.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]