qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 11/11] chardev: add pty chardev support to chard

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 11/11] chardev: add pty chardev support to chardev-add (qmp)
Date: Thu, 10 Jan 2013 10:14:39 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121116 Thunderbird/10.0.11 
  Hi,

> But do we really need it to be that complex?  Why not just use a
> type with an optional member, instead of going through a union:
> 
> { 'type' : 'ChardevReturn', 'data': { '*pty' : 'str' } }

Yes, should do, we don't have to pass back the chardev type here.

thanks,
  Gerd
reply via email to
[Prev in Thread] Current Thread [Next in Thread]