[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/12] tap: multiqueue support
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 01/12] tap: multiqueue support |
Date: |
Thu, 10 Jan 2013 09:32:16 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jan 09, 2013 at 11:25:24PM +0800, Jason Wang wrote:
> On 01/09/2013 05:56 PM, Stefan Hajnoczi wrote:
> > On Fri, Dec 28, 2012 at 06:31:53PM +0800, Jason Wang wrote:
> >> diff --git a/qapi-schema.json b/qapi-schema.json
> >> index 5dfa052..583eb7c 100644
> >> --- a/qapi-schema.json
> >> +++ b/qapi-schema.json
> >> @@ -2465,7 +2465,7 @@
> >> { 'type': 'NetdevTapOptions',
> >> 'data': {
> >> '*ifname': 'str',
> >> - '*fd': 'str',
> >> + '*fd': ['String'],
> > This change is not backwards-compatible. You need to add a '*fds':
> > ['String'] field instead.
>
> I'm not quite understand this case, I think it still work when we we
> just specify one fd.
You are right, the QemuOpts visitor shows no incompatibility.
But there is also a QMP interface: netdev_add. I think changing the
type to a string list breaks compatibility there.
Stefan