[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 03/11] block: add snapshot and image info que
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V2 03/11] block: add snapshot and image info query function |
Date: |
Wed, 09 Jan 2013 08:56:25 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
On 01/08/2013 10:12 PM, Wenchao Xia wrote:
> This patch added function bdrv_query_image_info() and
> bdrv_query_snapshot_infolist(), which will return info in qmp object
> format. The implemetion code are mostly copied from collect_image_info()
s/implemetion/implementation/
> and collect_snapshot() in qemu-img.c.
> To help filter out snapshot info not needed, a call back function is
> added in bdrv_query_snapshot_infolist().
>
> v2:
Generally, the v2 information should go...
> Seperate patch for adding these functions.
> Spelling fix.
> Coding style fix due to comments from Eric.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
...here, after the S-o-b and --- separator. It is useful for email
review, but doesn't need to clutter the final git history.
> block.c | 117
> +++++++++++++++++++++++++++++++++++++++++++++++++
> include/block/block.h | 9 ++++
> 2 files changed, 126 insertions(+), 0 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH V2 04/11] qemu-img: switch image retrieving function, Wenchao Xia, 2013/01/09
[Qemu-devel] [PATCH V2 07/11] block: export function bdrv_find_snapshot(), Wenchao Xia, 2013/01/09
[Qemu-devel] [PATCH V2 02/11] block: add bdrv_get_filename() function, Wenchao Xia, 2013/01/09
[Qemu-devel] [PATCH V2 08/11] qmp: add interface query-snapshots, Wenchao Xia, 2013/01/09
[Qemu-devel] [PATCH V2 05/11] block: rename bdrv_query_info to bdrv_query_block_info, Wenchao Xia, 2013/01/09