[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 08/61] virtio-blk : show VirtIOBlock structure.

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 08/61] virtio-blk : show VirtIOBlock structure.
Date: Tue, 8 Jan 2013 16:18:53 +0000

On 7 January 2013 18:40,  <address@hidden> wrote:
> virtio-blk : show VirtIOBlock structure.

If this survives as a separate patch then this should read
"virtio-blk: make VirtIOBlock structure public"

> As we discuss with anthony and andreas, this structure must be showed to avoid
> two memory allocations for virtio-blk-x.

I don't really like chatty references to mailing list discussions in
commit messages; commit messages should just confidently
say what/why they're making the change. You can always put
in remarks below the '---' line if you want to remind reviewers of
earlier discussion. Similarly, you don't need to say "must be
committed after patches X and Y" in the commit message proper --
as a git commit the order is inherent.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]