Re: [Qemu-devel] [Virt-test-devel] [Autotest PATCH 2/2] virt run: add three logical case filters

[Qingtang Zhou]

* On 2012-12-31 17:55:24 -0200, Lucas Meneghel Rodrigues (address@hidden) wrote:
> Hmmm, about this one, I'm worried about making things more complex...
> 
> The way I see the problem at hand, I'd say if people want to customize
> things, they'd be better of creating their own, specialized config
> files rather than adding command line flags to manipulate the test
> sets.
Which kind of user interface do you want to provide to us (autotest user)?
A cli? But why does it can't specify more parameters or filters?
A config file? Why don't allow us to update tests.cfg?

I'm totally confused.

And why must I download that JeOS image?
I've setup my own image, why can't I use it directly?

Well, I prefer the old autotest style more now.

> 
> So my initial stand on this particular patch is NACK, but you might
> convince me otherwise :)
> 
> On Sat, Dec 29, 2012 at 11:10 PM, Amos Kong <address@hidden> wrote:
> > On Sun, Dec 30, 2012 at 09:02:09AM +0800, Amos Kong wrote:
> >> This patch added there options for filtering cases by logics,
> >>
> >> For example:
> >> ./run -t qemu -c tests.cfg --oronly="WinXP Win7" --andonly="boot 64" 
> >> --not="sp1"
> >
> > Oh! a typo in commitlog
> >
> >  ./run -t qemu -c tests.cfg --or="WinXP Win7" --and="boot 64" --not="sp1"
> >
> >>   (following cases will be executed)
> >>
> >> Test    1: virtio_blk.smp2.virtio_net.WinXP.64.boot
> >> Test    2: virtio_blk.smp2.virtio_net.Win7.64.boot
> > ...