[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler()
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque |
|
Date: |
Thu, 03 Jan 2013 09:20:34 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121116 Thunderbird/10.0.11 |
On 01/02/13 16:56, Stefan Hajnoczi wrote:
> On Wed, Dec 19, 2012 at 02:07:16PM +0100, Stefan Hajnoczi wrote:
>> The spice_server pointer is a global variable and
>> vm_change_state_handler() therefore does not use its opaque parameter.
>>
>> The vm change state handler is added with a pointer to the spice_server
>> pointer. This is useless and we probably would not want 2 levels of
>> pointers.
> Gerd, would you like to take this through the spice queue or should I
> put it in trivial-patches?
Taking through trivial is fine with me, especially as the spice patch
queue is empty atm ;)
thanks,
Gerd