[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/20] target-i386: replace uint32_t vendor fiel
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH 10/20] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t |
Date: |
Fri, 28 Dec 2012 21:01:47 +0100 |
On Fri, 28 Dec 2012 15:39:19 -0200
Eduardo Habkost <address@hidden> wrote:
> On Thu, Dec 27, 2012 at 03:59:26PM +0100, Igor Mammedov wrote:
> [...]
> > assert(kvm_enabled());
> >
> > x86_cpu_def->name = "host";
> > - host_cpuid(0x0, 0, &eax, &ebx, &ecx, &edx);
> > - x86_cpu_def->vendor1 = ebx;
> > - x86_cpu_def->vendor2 = edx;
> > - x86_cpu_def->vendor3 = ecx;
> > + x86cpu_vendor_words2str(x86_cpu_def->vendor, ebx, edx, ecx);
>
> Oops: you removed the host_cpuid() call by mistake, so now we're filling
> the vendor string with zeroes.
fixed in v4 series
Thanks!
>
> Reviewed-by withdrawn.
>
> --
> Eduardo
--
Regards,
Igor
- Re: [Qemu-devel] [PATCH 04/20] target-i386: setting default 'vendor' is obsolete, remove it, (continued)
- [Qemu-devel] [PATCH 05/20] target-i386: move setting defaults out of cpu_x86_parse_featurestr(), Igor Mammedov, 2012/12/27
- [Qemu-devel] [PATCH 07/20] target-i386: cpu_x86_register() consolidate freeing resources, Igor Mammedov, 2012/12/27
- [Qemu-devel] [PATCH 09/20] target-i386: add x86cpu_vendor_words2str(), Igor Mammedov, 2012/12/27
- [Qemu-devel] [PATCH 10/20] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t, Igor Mammedov, 2012/12/27
- [Qemu-devel] [PATCH 11/20] target-i386: remove vendor_override field from CPUX86State, Igor Mammedov, 2012/12/27
- [Qemu-devel] [PATCH 06/20] target-i386: move out CPU features initialization in separate func, Igor Mammedov, 2012/12/27
- [Qemu-devel] [PATCH 08/20] target-i386: move kvm_check_features_against_host() check to realize time, Igor Mammedov, 2012/12/27
- [Qemu-devel] [PATCH 12/20] target-i386: prepare cpu_x86_parse_featurestr() to return a set of key, value property pairs, Igor Mammedov, 2012/12/27
- [Qemu-devel] [PATCH 16/20] target-i386: set custom 'level' without intermediate x86_def_t, Igor Mammedov, 2012/12/27