Re: [Qemu-devel] [PATCH] Fix SWI (SVC) instruction in THUMB.

[Peter Maydell]

On 25 December 2012 14:21, Alex Rozenman <address@hidden> wrote:
> target-arm/helper.c (do_interrupt_v7m): When do_interrupt_v7m is called,
> PC is already points to a correct instruction (after the SVC one). Don't
> modify the PC here.

Looks plausible, but (a) your commit message doesn't make it clear that this bug
only applies to SWI on M profile cores, not AR, and (b) could probably
use the comment that is present in the AR-core equivalent of this code:
 /* The PC already points to the next instruction.  */

This is one of those "surprised nobody's noticed this one before" bugs, do
the RTOSes we've tested with really not use SWI?

-- PMM