[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH qom-cpu 2/7] target-mips: Clean up mips_cpu_map_tc()
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PATCH qom-cpu 2/7] target-mips: Clean up mips_cpu_map_tc() documentation |
Date: |
Wed, 19 Dec 2012 16:31:06 +0100 |
This function will be touched again soon, so a good understanding of env
vs. other helps. Adopt gtk-doc style.
Signed-off-by: Andreas Färber <address@hidden>
---
target-mips/op_helper.c | 14 +++++++++-----
1 Datei geändert, 9 Zeilen hinzugefügt(+), 5 Zeilen entfernt(-)
diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
index f9f2b23..83998ab 100644
--- a/target-mips/op_helper.c
+++ b/target-mips/op_helper.c
@@ -573,11 +573,15 @@ static inline void mips_tc_sleep(MIPSCPU *cpu, int tc)
}
}
-/* tc should point to an int with the value of the global TC index.
- This function will transform it into a local index within the
- returned CPUMIPSState.
-
- FIXME: This code assumes that all VPEs have the same number of TCs,
+/**
+ * mips_cpu_map_tc:
+ * @env: CPU from which mapping is performed.
+ * @tc: Should point to an int with the value of the global TC index.
+ *
+ * This function will transform @tc into a local index within the
+ * returned #CPUMIPSState.
+ */
+/* FIXME: This code assumes that all VPEs have the same number of TCs,
which depends on runtime setup. Can probably be fixed by
walking the list of CPUMIPSStates. */
static CPUMIPSState *mips_cpu_map_tc(CPUMIPSState *env, int *tc)
--
1.7.10.4
- [Qemu-devel] [PATCH qom-cpu 0/7] QOM CPUState, part 7: CPU_COMMON for topology, Andreas Färber, 2012/12/19
- [Qemu-devel] [PATCH qom-cpu 3/7] cpu: Move numa_node field to CPUState, Andreas Färber, 2012/12/19
- [Qemu-devel] [PATCH qom-cpu 2/7] target-mips: Clean up mips_cpu_map_tc() documentation,
Andreas Färber <=
- [Qemu-devel] [PATCH qom-cpu 1/7] cpu: Move nr_{cores, threads} fields to CPUState, Andreas Färber, 2012/12/19
- [Qemu-devel] [PATCH qom-cpu 5/7] kvm: Pass CPUState to kvm_init_vcpu(), Andreas Färber, 2012/12/19
- [Qemu-devel] [PATCH qom-cpu 6/7] xen: Simplify halting of first CPU, Andreas Färber, 2012/12/19
- [Qemu-devel] [PATCH qom-cpu 7/7] exec: Return CPUState from qemu_get_cpu(), Andreas Färber, 2012/12/19
- [Qemu-devel] [PATCH qom-cpu 4/7] cpu: Move cpu_index field to CPUState, Andreas Färber, 2012/12/19