qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/3] target-i386/cpu.c: coding style fix


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH 1/3] target-i386/cpu.c: coding style fix
Date: Tue, 18 Dec 2012 16:41:30 -0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Dec 18, 2012 at 07:33:13PM +0100, Andreas Färber wrote:
> Am 18.12.2012 18:03, schrieb Eduardo Habkost:
> > On Tue, Dec 18, 2012 at 05:44:12PM +0100, Igor Mammedov wrote:
> >> On Tue, 18 Dec 2012 14:29:21 -0200
> >> Eduardo Habkost <address@hidden> wrote:
> >>
> >>> Signed-off-by: Eduardo Habkost <address@hidden>
> >>> ---
> >>>  target-i386/cpu.c | 5 +++--
> >>>  1 file changed, 3 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> >>> index 2d4fc42..fe27def 100644
> >>> --- a/target-i386/cpu.c
> >>> +++ b/target-i386/cpu.c
> >>> @@ -1789,10 +1789,11 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t
> >>> index, uint32_t count, /* XXX: The physical address space is limited to 42
> >>> bits in exec.c. */ *eax = 0x00003028;     /* 48 bits virtual, 40 bits
> >>                                        ^^ you forgot TAB here 
> > 
> > See patch 2/3.  :-)
> 
> Can I just squash that into this one?

Yes, sure.

I was keeping both changes separate on my git tree while
working/rebasing the series, but I should have squashed them before
submitting (as both are just "coding style fixes").

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]