[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 12/12] virtio-blk: add x-data-plane=on|off pe
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v6 12/12] virtio-blk: add x-data-plane=on|off performance feature |
Date: |
Sun, 16 Dec 2012 18:08:53 +0200 |
On Mon, Dec 10, 2012 at 02:09:45PM +0100, Stefan Hajnoczi wrote:
> @@ -33,6 +34,7 @@ typedef struct VirtIOBlock
> VirtIOBlkConf *blk;
> unsigned short sector_mask;
> DeviceState *qdev;
> + VirtIOBlockDataPlane *dataplane;
> } VirtIOBlock;
>
> static VirtIOBlock *to_virtio_blk(VirtIODevice *vdev)
> @@ -407,6 +409,14 @@ static void virtio_blk_handle_output(VirtIODevice *vdev,
> VirtQueue *vq)
> .num_writes = 0,
> };
>
> + /* Some guests kick before setting VIRTIO_CONFIG_S_DRIVER_OK so start
> + * dataplane here instead of waiting for .set_status().
> + */
By the way which guests are these?
> + if (s->dataplane) {
> + virtio_blk_data_plane_start(s->dataplane);
> + return;
> + }
> +
By the way it's chunk such as this that I meant: it's not
compiled out even if dataplane is disabled by configure.
Naither is the extra field in the struct.
> while ((req = virtio_blk_get_request(s))) {
> virtio_blk_handle_request(req, &mrb);
> }
- Re: [Qemu-devel] [PATCH v6 03/12] dataplane: add host memory mapping code, (continued)
[Qemu-devel] [PATCH v6 05/12] dataplane: add event loop, Stefan Hajnoczi, 2012/12/10
[Qemu-devel] [PATCH v6 07/12] iov: add iov_discard_front/back() to remove data, Stefan Hajnoczi, 2012/12/10
[Qemu-devel] [PATCH v6 04/12] dataplane: add virtqueue vring code, Stefan Hajnoczi, 2012/12/10
[Qemu-devel] [PATCH v6 06/12] dataplane: add Linux AIO request queue, Stefan Hajnoczi, 2012/12/10
[Qemu-devel] [PATCH v6 12/12] virtio-blk: add x-data-plane=on|off performance feature, Stefan Hajnoczi, 2012/12/10
- Re: [Qemu-devel] [PATCH v6 12/12] virtio-blk: add x-data-plane=on|off performance feature,
Michael S. Tsirkin <=
Re: [Qemu-devel] [PATCH v6 00/12] virtio: virtio-blk data plane, Stefan Hajnoczi, 2012/12/10
[Qemu-devel] [PATCH v6 02/12] configure: add CONFIG_VIRTIO_BLK_DATA_PLANE, Stefan Hajnoczi, 2012/12/10
[Qemu-devel] [PATCH v6 08/12] test-iov: add iov_discard_front/back() testcases, Stefan Hajnoczi, 2012/12/10
[Qemu-devel] [PATCH v6 11/12] dataplane: add virtio-blk data plane code, Stefan Hajnoczi, 2012/12/10
[Qemu-devel] [PATCH v6 09/12] iov: add qemu_iovec_concat_iov(), Stefan Hajnoczi, 2012/12/10
[Qemu-devel] [PATCH v6 10/12] virtio-blk: restore VirtIOBlkConf->config_wce flag, Stefan Hajnoczi, 2012/12/10
Re: [Qemu-devel] [PATCH v6 00/12] virtio: virtio-blk data plane, Stefan Hajnoczi, 2012/12/11