[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version |
Date: |
Fri, 14 Dec 2012 08:54:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121116 Thunderbird/10.0.11 |
Hi,
>> If you send me a fix for 6e72719e721a40fe1224701ca10edc1caf0cd708
>> I'll go revert 288fa40736e6eb63132d01aa6dc21ee831b796ae
>
> 6e72719 is perfectly sane, because it brings consistency into the
> file. Now both users of PIXMAN_TYPE_BGRA are guarded by the same
> #ifdef.
Both users? Hello? Its two *different* types: PIXMAN_TYPE_RGBA and
PIXMAN_TYPE_BGRA. And, yes, they have been added in different versions.
So guarding them with the *same* #ifdef is wrong.
> #ifdef PIXMAN_TYPE_BGRA
It's a enum, not a #define, so this isn't going to fly.
cheers,
Gerd
- [Qemu-devel] [PATCH 0/2] pixman: two little fixes., Gerd Hoffmann, 2012/12/10
- [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version, Gerd Hoffmann, 2012/12/10
- Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version, Alexander Graf, 2012/12/13
- Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version, Gerd Hoffmann, 2012/12/13
- Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version, Alexander Graf, 2012/12/13
- Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version, Gerd Hoffmann, 2012/12/13
- Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version, Alexander Graf, 2012/12/13
- Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version, Alexander Graf, 2012/12/14
- Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version, Alexander Graf, 2012/12/13
[Qemu-devel] [PATCH 2/2] pixman: update internal copy to pixman-0.28.2, Gerd Hoffmann, 2012/12/10