[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] s390: Move IPL code into a separate device
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] s390: Move IPL code into a separate device |
Date: |
Wed, 12 Dec 2012 20:56:35 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
On 12/12/12 14:31, Alexander Graf wrote:
>> +void s390_ipl_cpu(uint64_t pswaddr)
>
> Any reason this isn't inlined inside the reset handler? And why is this
> public?
Well, the former patch version had the disk bootmap parsing in a separate
file, but we can certainly unexport that and make it inline in this patch.
[...]
>> +#define KERN_IMAGE_START 0x010000UL
>> +#define KERN_PARM_AREA 0x010480UL
>> +#define INITRD_START 0x800000UL
>> +#define INITRD_PARM_START 0x010408UL
>> +#define INITRD_PARM_SIZE 0x010410UL
>> +#define PARMFILE_START 0x001000UL
>> +#define ZIPL_FILENAME "s390-zipl.rom"
>> +#define ZIPL_IMAGE_START 0x009000UL
>> +#define IPL_PSW_MASK 0x0000000180000000ULL
>
> I don't think we need the above values outside of ipl.c, no? :)
See above.
Will move that into ipl.c