Re: [Qemu-devel] [RFC] i.MX233 / olinuxino support

[Peter Maydell]

On 11 December 2012 13:08, M P <address@hidden> wrote:
> I've added imx23 support to qemu, with quite a lot of working peripherals,
> and enough to boot linux with SD card and USB working. There are bits
> missing (audio, video outputs) but it's otherwise working pretty well.
>
> I've collated and cleaned the patches onto this github branch, I'd
> appreciate any comments and/or complementary work before I submit the
> patches for merging here...
>
> https://github.com/buserror-uk/qemu-buserror/commits/dev-imx233

"Showing 11 changed files with 2,236 additions and 0 deletions."

That commit absolutely has to be broken up into a coherent set of
smaller patches; it is far too big to code review as it stands.

You don't seem to be following the QEMU coding style. (CODING_STYLE
and scripts/checkpatch.pl may be of use).

Information on how to test the board model would be good. Also
unit tests, maybe?

Are you going to be sticking around to help maintain and improve
the board model in the future?

http://wiki.qemu.org/Contribute/SubmitAPatch has more pointers
on patch submission.

thanks
-- PMM