[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 20/35] migration: move begining stage to the migrati
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH 20/35] migration: move begining stage to the migration thread |
Date: |
Tue, 11 Dec 2012 13:46:56 +0100 |
Signed-off-by: Juan Quintela <address@hidden>
---
migration.c | 30 +++++++++++++++++-------------
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/migration.c b/migration.c
index 913f3bc..336941b 100644
--- a/migration.c
+++ b/migration.c
@@ -672,7 +672,6 @@ static int64_t buffered_get_rate_limit(void *opaque)
static bool migrate_fd_put_ready(MigrationState *s, uint64_t max_size)
{
int ret;
- static bool first_time = true;
uint64_t pending_size;
bool last_round = false;
@@ -682,17 +681,6 @@ static bool migrate_fd_put_ready(MigrationState *s,
uint64_t max_size)
qemu_mutex_unlock_iothread();
return false;
}
- if (first_time) {
- first_time = false;
- DPRINTF("beginning savevm\n");
- ret = qemu_savevm_state_begin(s->file, &s->params);
- if (ret < 0) {
- DPRINTF("failed, %d\n", ret);
- migrate_fd_error(s);
- qemu_mutex_unlock_iothread();
- return false;
- }
- }
DPRINTF("iterate\n");
pending_size = qemu_savevm_state_pending(s->file, max_size);
@@ -741,9 +729,21 @@ static bool migrate_fd_put_ready(MigrationState *s,
uint64_t max_size)
static void *buffered_file_thread(void *opaque)
{
QEMUFileBuffered *s = opaque;
+ MigrationState *m = s->migration_state;
int64_t initial_time = qemu_get_clock_ms(rt_clock);
int64_t max_size = 0;
bool last_round = false;
+ int ret;
+
+ qemu_mutex_lock_iothread();
+ DPRINTF("beginning savevm\n");
+ ret = qemu_savevm_state_begin(m->file, &m->params);
+ if (ret < 0) {
+ DPRINTF("failed, %d\n", ret);
+ qemu_mutex_unlock_iothread();
+ goto out;
+ }
+ qemu_mutex_unlock_iothread();
while (true) {
int64_t current_time = qemu_get_clock_ms(rt_clock);
@@ -775,10 +775,14 @@ static void *buffered_file_thread(void *opaque)
DPRINTF("file is ready\n");
if (s->bytes_xfer < s->xfer_limit) {
DPRINTF("notifying client\n");
- last_round = migrate_fd_put_ready(s->migration_state, max_size);
+ last_round = migrate_fd_put_ready(m, max_size);
}
}
+out:
+ if (ret < 0) {
+ migrate_fd_error(m);
+ }
g_free(s->buffer);
g_free(s);
return NULL;
--
1.7.11.7
- [Qemu-devel] [PATCH 12/35] buffered_file: unfold buffered_append in buffered_put_buffer, (continued)
- [Qemu-devel] [PATCH 12/35] buffered_file: unfold buffered_append in buffered_put_buffer, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 13/35] savevm: New save live migration method: pending, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 15/35] migration-fd: remove duplicate include, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 10/35] buffered_file: Unfold the trick to restart generating migration data, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 18/35] migration: Inline qemu_fopen_ops_buffered into migrate_fd_connect, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 23/35] migration: unfold rest of migrate_fd_put_ready() into thread, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 17/35] migration: move migration_fd_put_ready(), Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 16/35] migration: move buffered_file.c code into migration.c, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 22/35] migration: move exit condition to migration thread, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 28/35] migration: Only go to the iterate stage if there is anything to send, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 20/35] migration: move begining stage to the migration thread,
Juan Quintela <=
- [Qemu-devel] [PATCH 19/35] migration: move migration notifier, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 25/35] ram: Add last_sent_block, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 21/35] migration: Add buffered_flush error handling, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 27/35] ram: Use memory_region_test_and_clear_dirty, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 26/35] memory: introduce memory_region_test_and_clear_dirty, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 24/35] ram: rename last_block to last_seen_block, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 35/35] migration: print times for end phase, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 32/35] ram: add free_space parameter to save_live functions, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 30/35] ram: account the amount of transferred ram better, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 29/35] ram: optimize migration bitmap walking, Juan Quintela, 2012/12/11