[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks |
Date: |
Fri, 7 Dec 2012 11:55:16 -0200 |
On Fri, 07 Dec 2012 17:39:32 +0900
Tomoki Sekiyama <address@hidden> wrote:
> Adds sample hook scripts for --fsfreeze-hook option of qemu-ga.
> - fsfreeze-hook : execute scripts in fsfreeze-hook.d/
> - fsfreeze-hook.d/mysql-flush.sh.sample : quiesce MySQL before snapshot
>
> Signed-off-by: Tomoki Sekiyama <address@hidden>
> ---
> .gitignore | 1
> Makefile | 2 -
> scripts/qemu-guest-agent/fsfreeze-hook | 33 ++++++++++++
> .../fsfreeze-hook.d/mysql-flush.sh.sample | 55
> ++++++++++++++++++++
> 4 files changed, 90 insertions(+), 1 deletion(-)
> create mode 100755 scripts/qemu-guest-agent/fsfreeze-hook
> create mode 100755
> scripts/qemu-guest-agent/fsfreeze-hook.d/mysql-flush.sh.sample
>
> diff --git a/.gitignore b/.gitignore
> index bd6ba1c..286822d 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -93,3 +93,4 @@ cscope.*
> tags
> TAGS
> *~
> +!scripts/qemu-guest-agent/fsfreeze-hook.d
Why? Do we expect to have *~ files in there?
> diff --git a/Makefile b/Makefile
> index 9ecbcbb..466dcd7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -248,7 +248,7 @@ clean:
> # avoid old build problems by removing potentially incorrect old files
> rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h
> gen-op-arm.h
> rm -f qemu-options.def
> - find . -name '*.[od]' -exec rm -f {} +
> + find . -name '*.[od]' -type f -exec rm -f {} +
What does this change have to do with this patch?
> rm -f *.a *.lo $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~
> rm -Rf .libs
> rm -f qemu-img-cmds.h
> diff --git a/scripts/qemu-guest-agent/fsfreeze-hook
> b/scripts/qemu-guest-agent/fsfreeze-hook
> new file mode 100755
> index 0000000..4f7ff15
> --- /dev/null
> +++ b/scripts/qemu-guest-agent/fsfreeze-hook
> @@ -0,0 +1,33 @@
> +#!/bin/sh
> +
> +# This script is executed when a guest agent receives fsfreeze-freeze and
> +# fsfreeze-thaw command, if it is specified in --fsfreeze-hook (-F)
> +# option of qemu-ga or placed in default path (/etc/qemu/fsfreeze-hook).
> +# When the agent receives fsfreeze-freeze request, this script is issued with
> +# "freeze" argument before the filesystem is freezed. And for fsfreeze-thaw
> +# request, it is issued with "thaw" argument after filesystem is thawed.
> +
> +LOGFILE=/var/log/qga-fsfreeze-hook.log
> +FSFREEZE_D=$(dirname -- "$0")/fsfreeze-hook.d
> +
> +# Check whether file $1 is a backup or rpm-generated file and should be
> ignored
> +is_ignored_file() {
> + case "$1" in
> + *~ | *.bak | *.orig | *.rpmnew | *.rpmorig | *.rpmsave | *.sample)
> + return 0 ;;
> + esac
> + return 1
> +}
> +
> +# Iterate executables in directory "fsfreeze-hook.d" with the specified args
> +[ ! -d "$FSFREEZE_D" ] && exit 1
> +for file in "$FSFREEZE_D"/* ; do
> + is_ignored_file "$file" && continue
> + [ -x "$file" ] || continue
> + echo "$(date): execute $file $@" >>$LOGFILE
> + "$file" "$@" >>$LOGFILE 2>&1
> + STATUS=$?
> + echo "$(date): $file finished with status=$STATUS" >>$LOGFILE
> +done
> +
> +exit 0
> diff --git a/scripts/qemu-guest-agent/fsfreeze-hook.d/mysql-flush.sh.sample
> b/scripts/qemu-guest-agent/fsfreeze-hook.d/mysql-flush.sh.sample
> new file mode 100755
> index 0000000..c69b8ad
> --- /dev/null
> +++ b/scripts/qemu-guest-agent/fsfreeze-hook.d/mysql-flush.sh.sample
> @@ -0,0 +1,55 @@
> +#!/bin/sh
> +
> +# Flush MySQL tables to the disk before the filesystem is freezed.
> +# At the same time, this keeps a read lock in order to avoid write accesses
> +# from the other clients until the filesystem is thawed.
> +
> +MYSQL="/usr/bin/mysql"
> +MYSQL_OPTS="-uroot" #"-prootpassword"
> +FIFO=/tmp/mysql-flush.fifo
> +MYSQL_CMD="$MYSQL $MYSQL_OPTS"
> +
> +# Check mysql is installed and the server running
> +[ -x $MYSQL ] && $MYSQL_CMD < /dev/null || exit 0
> +
> +flush_and_wait() {
> + printf "FLUSH TABLES WITH READ LOCK \\G\n"
> + read < $FIFO
> + printf "UNLOCK TABLES \\G\n"
> +}
> +
> +case "$1" in
> + freeze)
> + mkfifo $FIFO || exit 1
> + flush_and_wait | $MYSQL_CMD &
> + # wait until every block is flushed
> + while [ "$(echo 'SHOW STATUS LIKE "Key_blocks_not_flushed"' |\
> + $MYSQL_CMD | tail -1 | cut -f 2)" -gt 0 ]; do
> + sleep 1
> + done
> + # for InnoDB, wait until every log is flushed
> + INNODB_STATUS=$(mktemp /tmp/mysql-flush.XXXXXX)
> + [ $? -ne 0 ] && exit 2
> + trap "rm -f $INNODB_STATUS" SIGINT
> + while :; do
> + printf "SHOW ENGINE INNODB STATUS \\G" | $MYSQL_CMD >
> $INNODB_STATUS
> + LOG_CURRENT=$(grep 'Log sequence number' $INNODB_STATUS |\
> + tr -s ' ' | cut -d' ' -f4)
> + LOG_FLUSHED=$(grep 'Log flushed up to' $INNODB_STATUS |\
> + tr -s ' ' | cut -d' ' -f5)
> + [ "$LOG_CURRENT" = "$LOG_FLUSHED" ] && break
> + sleep 1
> + done
> + rm -f $INNODB_STATUS
> + ;;
> +
> + thaw)
> + [ ! -p $FIFO ] && exit 1
> + echo > $FIFO
> + rm -f $FIFO
> + ;;
> +
> + *)
> + exit 1
> + ;;
> +esac
>
- [Qemu-devel] [PATCH v7 0/2] qemu-ga: add hook to quiesce the guest on fsfreeze-freeze/thaw, Tomoki Sekiyama, 2012/12/07
- Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks, Tomoki Sekiyama, 2012/12/07
- Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks,
Luiz Capitulino <=
- Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks, Eric Blake, 2012/12/07
- Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks, Luiz Capitulino, 2012/12/07
- Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks, Eric Blake, 2012/12/07
- Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks, Luiz Capitulino, 2012/12/07
- Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks, Tomoki Sekiyama, 2012/12/10
Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks, Eric Blake, 2012/12/07
Re: [Qemu-devel] [PATCH v7 1/2] qemu-ga: execute hook to quiesce the guest on fsfreeze-freeze/thaw, Tomoki Sekiyama, 2012/12/07