[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio: verify that all outstanding buffers are
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH] virtio: verify that all outstanding buffers are flushed (was Re: vmstate conversion for virtio?) |
Date: |
Thu, 6 Dec 2012 10:02:21 +0200 |
On Thu, Dec 06, 2012 at 04:33:06PM +1030, Rusty Russell wrote:
> "Michael S. Tsirkin" <address@hidden> writes:
> > Add sanity check to address the following concern:
> >
> > On Wed, Dec 05, 2012 at 09:47:22AM +1030, Rusty Russell wrote:
> >> All we need is the index of the request; the rest can be re-read from
> >> the ring.
>
> The terminology I used here was loose, indeed.
>
> We need the head of the chained descriptor, which we already read from
> the ring when we gathered the request.
So ack that patch?
> Currently we dump a massive structure; it's inelegant at the very least.
>
> Cheers,
> Rusty.
Hmm not sure what you refer to. I see this per ring:
qemu_put_be32(f, vdev->vq[i].vring.num);
qemu_put_be64(f, vdev->vq[i].pa);
qemu_put_be16s(f, &vdev->vq[i].last_avail_idx);
Looks like there's no way around savng these fields.
--
MST
- [Qemu-devel] vmstate conversion for virtio?, Rusty Russell, 2012/12/03
- Re: [Qemu-devel] vmstate conversion for virtio?, Michael S. Tsirkin, 2012/12/04
- Re: [Qemu-devel] vmstate conversion for virtio?, Juan Quintela, 2012/12/04
- Re: [Qemu-devel] vmstate conversion for virtio?, Rusty Russell, 2012/12/04
- [Qemu-devel] [PATCH] virtio: verify that all outstanding buffers are flushed (was Re: vmstate conversion for virtio?), Michael S. Tsirkin, 2012/12/05
- Re: [Qemu-devel] [PATCH] virtio: verify that all outstanding buffers are flushed (was Re: vmstate conversion for virtio?), Rusty Russell, 2012/12/06
- Re: [Qemu-devel] [PATCH] virtio: verify that all outstanding buffers are flushed (was Re: vmstate conversion for virtio?),
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH] virtio: verify that all outstanding buffers are flushed (was Re: vmstate conversion for virtio?), Rusty Russell, 2012/12/06
- Re: [Qemu-devel] [PATCH] virtio: verify that all outstanding buffers are flushed (was Re: vmstate conversion for virtio?), Anthony Liguori, 2012/12/10
- Re: [Qemu-devel] [PATCH] virtio: verify that all outstanding buffers are flushed (was Re: vmstate conversion for virtio?), Rusty Russell, 2012/12/10
- Re: [Qemu-devel] [PATCH] virtio: verify that all outstanding buffers are flushed (was Re: vmstate conversion for virtio?), Michael S. Tsirkin, 2012/12/10