[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] target-i386:make hw_breakpoint_enabled retu
From: |
li guang |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] target-i386:make hw_breakpoint_enabled return bool type |
Date: |
Wed, 05 Dec 2012 08:51:25 +0800 |
在 2012-12-04二的 11:26 +0000,Peter Maydell写道:
> On 4 December 2012 11:11, Jan Kiszka <address@hidden> wrote:
> > On 2012-12-04 11:23, Peter Maydell wrote:
> >> Doesn't this break the use of this function in target-i386/seg_helper.c:
> >>
> >> if (hw_breakpoint_enabled(env->dr[7], i) == 0x1) {
> >>
> >> which specifically wants to determine whether the breakpoint is
> >> enabled only locally?
It was changed to 'if (hw_breakpoint_enabled(env->dr[7], i)) {'
in patch 3/3
> >
> > It does. And that also indicates the function is misnamed. Something
> > like hw_breakpoint_state might be better.
>
misnamed? I think hw_breakpoint_enabled is ask whether breakpoint
^^^^^^^^
is enabled or not, so it's almost suitable.
> And/or we could just refactor the code in seg_helper.c, which is
> a nasty mix of direct access to dr[7] and using the hw_breakpoint_*
> functions.
>
> -- PMM
--
regards!
li guang
- [Qemu-devel] [PATCH 1/3] target-i386:define name of breakpoint bit in dr7, liguang, 2012/12/04
- [Qemu-devel] [PATCH 2/3] target-i386:make hw_breakpoint_enabled return bool type, liguang, 2012/12/04
- Re: [Qemu-devel] [PATCH 2/3] target-i386:make hw_breakpoint_enabled return bool type, Peter Maydell, 2012/12/04
- Re: [Qemu-devel] [PATCH 2/3] target-i386:make hw_breakpoint_enabled return bool type, Jan Kiszka, 2012/12/04
- Re: [Qemu-devel] [PATCH 2/3] target-i386:make hw_breakpoint_enabled return bool type, Peter Maydell, 2012/12/04
- Re: [Qemu-devel] [PATCH 2/3] target-i386:make hw_breakpoint_enabled return bool type,
li guang <=
- Re: [Qemu-devel] [PATCH 2/3] target-i386:make hw_breakpoint_enabled return bool type, Jan Kiszka, 2012/12/05
- Re: [Qemu-devel] [PATCH 2/3] target-i386:make hw_breakpoint_enabled return bool type, li guang, 2012/12/05
- Re: [Qemu-devel] [PATCH 2/3] target-i386:make hw_breakpoint_enabled return bool type, li guang, 2012/12/05
Re: [Qemu-devel] [PATCH 1/3] target-i386:define name of breakpoint bit in dr7, Peter Maydell, 2012/12/04
[Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function, liguang, 2012/12/04