|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH] target-mips: Fix incorrect shift for SHILO and SHILOV |
Date: | Tue, 04 Dec 2012 13:43:47 -0600 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
On 2012-12-04 13:00, Blue Swirl wrote: >> > + if (rs5_0 == 0) >> > + return; > The check should be moved to translation time so that the call to this > helper is not generated at all. No, we'd do that only if this value were an immediate. Branch over helper is not an optimization for an edge case runtime value. r~
[Prev in Thread] | Current Thread | [Next in Thread] |