qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] target-mips: Fix incorrect shift for SHILO and


From: Blue Swirl
Subject: Re: [Qemu-devel] [PATCH] target-mips: Fix incorrect shift for SHILO and SHILOV
Date: Tue, 4 Dec 2012 19:52:58 +0000

On Tue, Dec 4, 2012 at 7:43 PM, Richard Henderson <address@hidden> wrote:
> On 2012-12-04 13:00, Blue Swirl wrote:
>>> > +    if (rs5_0 == 0)
>>> > +        return;
>> The check should be moved to translation time so that the call to this
>> helper is not generated at all.
>
> No, we'd do that only if this value were an immediate.
> Branch over helper is not an optimization for an edge case runtime value.

Right, for some reason I thought rs was a register number, sorry.

>
>
> r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]