qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V6 08/10] Create four opts list related function


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH V6 08/10] Create four opts list related functions
Date: Mon, 3 Dec 2012 13:06:42 +0100

On Fri, Nov 23, 2012 at 8:47 AM, Dong Xu Wang
<address@hidden> wrote:
> +/* Create a new QemuOptsList and make its desc to the merge of first and 
> second.
> + * It will allocate space for one new QemuOptsList plus enouth space for

s/enouth/enough/

> +    dest->name = "append_opts_list";
> +    dest->implied_opt_name = NULL;
> +    dest->merge_lists = false;
> +    QTAILQ_INIT(&dest->head);
> +    while (first && (first->desc[i].name)) {
> +        if (!find_desc_by_name(dest->desc, first->desc[i].name)) {
> +            dest->desc[index].name = g_strdup(first->desc[i].name);
> +            dest->desc[index].help = g_strdup(first->desc[i].help);
> +            dest->desc[index].type = first->desc[i].type;
> +            dest->desc[index].def_print_str =
> +                g_strdup(first->desc[i].def_print_str);
> +            ++index;
> +       }
> +        i++;

4-space indentation?  scripts/checkpatch.pl normally detects problems
with whitespace.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]