[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/10] qemu-ga: qmp_guest_file_close(): fix fclo
From: |
mdroth |
Subject: |
Re: [Qemu-devel] [PATCH 02/10] qemu-ga: qmp_guest_file_close(): fix fclose() error check |
Date: |
Wed, 28 Nov 2012 11:02:37 -0600 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Nov 27, 2012 at 11:01:56AM -0200, Luiz Capitulino wrote:
> fclose() returns EOF on error.
>
> Signed-off-by: Luiz Capitulino <address@hidden>
Reviewed-by: Michael Roth <address@hidden>
> ---
> qga/commands-posix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index a2216f2..c284083 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -170,7 +170,7 @@ void qmp_guest_file_close(int64_t handle, Error **err)
> }
>
> ret = fclose(gfh->fh);
> - if (ret == -1) {
> + if (ret == EOF) {
> error_set(err, QERR_QGA_COMMAND_FAILED, "fclose() failed");
> return;
> }
> --
> 1.8.0
>
- Re: [Qemu-devel] [PATCH 01/10] qemu-ga: guest_file_handle_find(): take an Error argument, (continued)
[Qemu-devel] [PATCH 02/10] qemu-ga: qmp_guest_file_close(): fix fclose() error check, Luiz Capitulino, 2012/11/27
- Re: [Qemu-devel] [PATCH 02/10] qemu-ga: qmp_guest_file_close(): fix fclose() error check,
mdroth <=
[Qemu-devel] [PATCH 08/10] qemu-ga: qmp_guest_network_get_interfaces(): get rid of snprintf() + error_set(), Luiz Capitulino, 2012/11/27
[Qemu-devel] [PATCH 05/10] qemu-ga: build_fs_mount_list(): take an Error argument, Luiz Capitulino, 2012/11/27
[Qemu-devel] [PATCH 10/10] qemu-ga: guest_suspend(): improve error reporting, Luiz Capitulino, 2012/11/27
[Qemu-devel] [PATCH 07/10] qemu-ga: qmp_guest_fstrim(): get rid of sprintf() + error_set(), Luiz Capitulino, 2012/11/27
[Qemu-devel] [PATCH 09/10] qemu-ga: bios_supports_mode(): improve error reporting, Luiz Capitulino, 2012/11/27