qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] scsi: Remove SCSI_BUS macro


From: Lei Li
Subject: [Qemu-devel] [PATCH] scsi: Remove SCSI_BUS macro
Date: Tue, 27 Nov 2012 13:37:52 +0800

As step behind Paolo's fix for RHBZ#879657 and according to the current
fix in Commit b5007bc (hmp: do not crash on invalid SCSI hotplug), the
macro SCSI_BUS has already been replaced to object_dynamic_cast which
has been improved when try to cast to NULL value and it is also what
DO_UPCAST macro does. And due to the potential Segmentation risk of
SCSI_BUS, remove this macro.


Signed-off-by: Lei Li <address@hidden>
---
 hw/scsi.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/hw/scsi.h b/hw/scsi.h
index b8f7357..ad063e5 100644
--- a/hw/scsi.h
+++ b/hw/scsi.h
@@ -142,7 +142,6 @@ struct SCSIBusInfo {
 };
 
 #define TYPE_SCSI_BUS "SCSI"
-#define SCSI_BUS(obj) OBJECT_CHECK(SCSIBus, (obj), TYPE_SCSI_BUS)
 
 struct SCSIBus {
     BusState qbus;
-- 
1.7.7.6




reply via email to

[Prev in Thread] Current Thread [Next in Thread]