[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBN
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges |
Date: |
Mon, 26 Nov 2012 10:24:30 +1100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Nov 23, 2012 at 04:01:58PM +0200, Michael S. Tsirkin wrote:
> On Fri, Nov 23, 2012 at 02:44:15PM +0100, Alexander Graf wrote:
> >
> > On 23.11.2012, at 14:44, Michael S. Tsirkin wrote:
> >
> > > On Fri, Nov 23, 2012 at 11:59:51PM +1100, David Gibson wrote:
> > >>> Look, even if solution using a required property is less elegant for CLI
> > >>> use, it will work, won't it?
> > >>> So how about we merge it so that things work, and then we can discuss a
> > >>> patch on top that auto-generates this property?
> > >>
> > >> Well, there you have a point. And actually I've realised there are
> > >> other things we need to assign uniquely for each PHB and don't yet (IO
> > >> window addresses). So I need to look at a wider rework of this, which
> > >> I'll start on next week.
> > >
> > > Fine. Basically my point is it's typically a mistake to
> > > make some userspace visible parameter depend on order
> > > of initialization of devices in qemu. I don't insist
> > > on making users fully specify such parameters but it
> > > is one way to do this.
> >
> > I think it's reasonable to require to be able to specify it. If you
> > don't, it's fine to base on device order IMHO.
>
> Let me clarify why it's not fine. My understanding is these addresses
> do not change across reboots on real hardware.
Well, the BUID would be expected to remain the same. The others
probably remain stable across reboots in practice, but I don't think
there's any reason they need to - the kernel will get the LIOBN and
window addresses from the device tree afresh on every boot.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges, (continued)
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges, Michael S. Tsirkin, 2012/11/22
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges, David Gibson, 2012/11/22
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges, Michael S. Tsirkin, 2012/11/23
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges, David Gibson, 2012/11/23
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges, Michael S. Tsirkin, 2012/11/23
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges, Alexander Graf, 2012/11/23
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges, Michael S. Tsirkin, 2012/11/23
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges, Alexander Graf, 2012/11/23
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges, Michael S. Tsirkin, 2012/11/23
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges, Alexander Graf, 2012/11/23
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges,
David Gibson <=
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges, Michael S. Tsirkin, 2012/11/21
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges, David Gibson, 2012/11/20
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges, Alexander Graf, 2012/11/21
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges, Michael S. Tsirkin, 2012/11/21
[Qemu-devel] [PATCH 10/12] pseries: Update SLOF for NVRAM support, David Gibson, 2012/11/12
Re: [Qemu-devel] [0/12] Pending pseries patches, Alexander Graf, 2012/11/19