[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for 1.3] target-i386: cpu: add missing flags to
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH for 1.3] target-i386: cpu: add missing flags to Haswell CPU model |
|
Date: |
Sun, 25 Nov 2012 19:33:12 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121025 Thunderbird/16.0.2 |
Am 22.11.2012 16:31, schrieb Eduardo Habkost:
> When adding the Haswell CPU model, I intended to make it a superset of the
> features present on the SandyBridge model, but I have removed the SEP and
> RDTSCP features from the feature list by mistake. This patch adds the missing
> SEP and RDTSCP features (that are present on SandyBridge) to Haswell.
>
> Reported-by: Martin Kletzander <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
Acked-by: Andreas Färber <address@hidden>
FWIW this is showing where QOM's imperative approach combined with
inheritance could greatly simplify things beyond your subclasses RFC.
Unfortunately I am not intimately familiar with all these models, so
counting on your help there. :)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg