Re: [Qemu-devel] [PATCH V10 1/8] isa: add isa_address_space_io

[Andreas Färber]

Am 19.09.2012 13:50, schrieb Julien Grall:
> This function permits to retrieve ISA IO address space.
> It will be usefull when we need to pass IO address space as argument.
> 
> Signed-off-by: Julien Grall <address@hidden>

Reviewed-by: Andreas Färber <address@hidden>

A note below:

> ---
>  hw/isa-bus.c |    9 +++++++++
>  hw/isa.h     |    1 +
>  2 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/isa-bus.c b/hw/isa-bus.c
> index f9b2373..c1d8309 100644
> --- a/hw/isa-bus.c
> +++ b/hw/isa-bus.c
> @@ -244,4 +244,13 @@ MemoryRegion *isa_address_space(ISADevice *dev)
>      return get_system_memory();
>  }
>  
> +MemoryRegion *isa_address_space_io(ISADevice *dev)
> +{
> +    if (dev) {
> +        return isa_bus_from_device(dev)->address_space_io;

This assumes that the device is attached to an ISABus already...

> +    }
> +
> +    return isabus->address_space_io;

...and that the ISABus has been set globally, which I think is an
assumption we make elsewhere as well, i.e. it cannot be used at
instance_init time but in qdev initfn/realizefn.

Andreas

> +}
> +
>  type_init(isabus_register_types)
> diff --git a/hw/isa.h b/hw/isa.h
> index dc97052..3891c1f 100644
> --- a/hw/isa.h
> +++ b/hw/isa.h
> @@ -43,6 +43,7 @@ void isa_bus_irqs(ISABus *bus, qemu_irq *irqs);
>  qemu_irq isa_get_irq(ISADevice *dev, int isairq);
>  void isa_init_irq(ISADevice *dev, qemu_irq *p, int isairq);
>  MemoryRegion *isa_address_space(ISADevice *dev);
> +MemoryRegion *isa_address_space_io(ISADevice *dev);
>  ISADevice *isa_create(ISABus *bus, const char *name);
>  ISADevice *isa_try_create(ISABus *bus, const char *name);
>  ISADevice *isa_create_simple(ISABus *bus, const char *name);
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg