[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] commit 094b287 "Add USB option in machine options" brok
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] commit 094b287 "Add USB option in machine options" broke i386 -usb |
Date: |
Thu, 22 Nov 2012 16:49:21 +0000 |
On 22 November 2012 16:39, Peter Maydell <address@hidden> wrote:
> We use "-usb" to enable USB in this command line. That has
> to continue to work, for back compatibility. I think your
> code to try to support -usb is broken:
> case QEMU_OPTION_usb:
> machine_opts = qemu_opts_find(qemu_find_opts("machine"), 0);
>
> will return NULL if there are no user-set machine opts
> at this point, so we never go on to try to set the usb
> machine opt to true.
Patch sent which fixes this bug.
-- PMM