[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] virtio-rng: use virtqueue_get_avail_bytes,
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] virtio-rng: use virtqueue_get_avail_bytes, fix migration |
Date: |
Wed, 21 Nov 2012 11:23:20 +0530 |
On (Tue) 20 Nov 2012 [19:44:55], Anthony Liguori wrote:
> Amit Shah <address@hidden> writes:
>
> > Popping an elem from the vq just to find out its length causes problems
> > with save/load later on. Use the new virtqueue_get_avail_bytes()
> > function instead, saves us the complexity in the migration code, as well
> > as makes the migration endian-safe.
> >
> > Signed-off-by: Amit Shah <address@hidden>
>
> To be clear, migration is already endian safe but this is definitely a
> very nice cleanup.
The in_addr and out_addr fields have pointers -- so endian- plus
word-length safety isn't guaranteed if migrating across architectures.
Amit
- [Qemu-devel] [PATCH 0/4] [For 0.13] virtio-rng: Fixes, Amit Shah, 2012/11/20
- [Qemu-devel] [PATCH 2/4] virtio-rng: remove extra request for entropy, Amit Shah, 2012/11/20
- [Qemu-devel] [PATCH 1/4] virtio-rng: use virtqueue_get_avail_bytes, fix migration, Amit Shah, 2012/11/20
- [Qemu-devel] [PATCH 3/4] virtio-rng: disable timer on device removal, Amit Shah, 2012/11/20
- [Qemu-devel] [PATCH 4/4] virtio-rng: fix typos, comments, Amit Shah, 2012/11/20