Re: [Qemu-devel] [PATCH] usb: host-linux: Ignore parsing errors of the device descriptors

[Jan Kiszka]

On 2012-11-15 09:28, Gerd Hoffmann wrote:
> On 11/15/12 09:23, Jan Kiszka wrote:
>> The Linux is more tolerant here as well: Just stop parsing the device
>> descriptors when an error is detected but do not reset what was found
>> so far. This allows to run buggy devices with partially invalid
>> descriptors.
> 
>> -error:
>> -    usb_ep_reset(&s->dev);
>> -    return 1;
> 
> I'd prefer to keep the error jump target to handle the parse error here.
> Dumping the reset there is fine with me, but I'd prefer this event being
> logged (trace point or stderr message or both) to ease trouble shooting
> in case a device doesn't behave as expected.

That would be "over-logging" as we already record the individual
reasons. There is simply no code to jump to after the refactoring.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux