[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] pixman: build internal version early
From: |
Johnson, Eric |
Subject: |
Re: [Qemu-devel] [PATCH 5/6] pixman: build internal version early |
Date: |
Tue, 13 Nov 2012 18:41:52 +0000 |
It's OK to add.
Signed-off-by: Eric Johnson <address@hidden>
I wasn't sure how to submit a patch to an unsubmitted patch. I haven't had a
chance to review the patch submission doc to see if that is covered. It would
still be useful info. I intend to recreate and supply my local sed replacement
of $(BUILD_DIR) and $(SRC_PATH) in $(QEMU_CFLAGS) patch to configure for patch
1 in this series to address Stefan's feedback. I had done that patch locally
prior to noticing Blue's and Gerd's patches on the list. And discarded since
trying Gerd's patch. It is trivial to recreate.
-Eric
> -----Original Message-----
> From: Peter Maydell [mailto:address@hidden
> Sent: Tuesday, November 13, 2012 10:30 AM
> To: Gerd Hoffmann
> Cc: address@hidden; Johnson, Eric
> Subject: Re: [Qemu-devel] [PATCH 5/6] pixman: build internal version early
>
> On 13 November 2012 08:42, Gerd Hoffmann <address@hidden> wrote:
> > Patch by Eric Johnson.
> >
> > Signed-off-by: Gerd Hoffmann <address@hidden>
>
> Does this need a Signed-off-by: from Eric? It's a pretty
> trivial patch but I guess it would be nice...
>
> thanks
> -- PMM
>
> > ---
> > configure | 7 ++++---
> > 1 files changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/configure b/configure
> > index e7ca78b..fb5f002 100755
> > --- a/configure
> > +++ b/configure
> > @@ -3953,9 +3953,6 @@ if test "$target_softmmu" = "yes" ; then
> > if test "$smartcard_nss" = "yes" ; then
> > echo "subdir-$target: subdir-libcacard" >> $config_host_mak
> > fi
> > - if test "$pixman" = "internal" ; then
> > - echo "subdir-$target: subdir-pixman" >> $config_host_mak
> > - fi
> > case "$target_arch2" in
> > i386|x86_64)
> > echo "CONFIG_HAVE_CORE_DUMP=y" >> $config_target_mak
> > @@ -4153,6 +4150,10 @@ echo "QEMU_INCLUDES+=$includes" >>
> $config_target_mak
> >
> > done # for target in $targets
> >
> > +if [ "$pixman" = "internal" ]; then
> > + echo "config-host.h: subdir-pixman" >> $config_host_mak
> > +fi
> > +
> > # build tree in object directory in case the source is not in the
> current directory
> > DIRS="tests tests/tcg tests/tcg/cris tests/tcg/lm32"
> > DIRS="$DIRS pc-bios/optionrom pc-bios/spapr-rtas"
> > --
> > 1.7.1
> >
> >
Re: [Qemu-devel] [PULL 0/6] pixman build fixes, Peter Maydell, 2012/11/13
Re: [Qemu-devel] [PULL 0/6] pixman build fixes, Anthony Liguori, 2012/11/14