[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [QEMU PATCH] microblaze: translate.c: Fix swaph decodin
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [QEMU PATCH] microblaze: translate.c: Fix swaph decoding |
Date: |
Fri, 9 Nov 2012 11:40:53 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Nov 08, 2012 at 02:01:19PM +1000, Peter Crosthwaite wrote:
> The swaph instruction was not decoding correctly. s/1e1/1e2 on the
> 9 LSBs on the instruction decode.
>
> Reported-by: David Holsgrove <address@hidden>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
> target-microblaze/translate.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-microblaze/translate.c b/target-microblaze/translate.c
> index 7d864b1..6f27c24 100644
> --- a/target-microblaze/translate.c
> +++ b/target-microblaze/translate.c
> @@ -840,7 +840,7 @@ static void dec_bit(DisasContext *dc)
> LOG_DIS("swapb r%d r%d\n", dc->rd, dc->ra);
> tcg_gen_bswap32_i32(cpu_R[dc->rd], cpu_R[dc->ra]);
> break;
> - case 0x1e1:
> + case 0x1e2:
Ouch.. I've applied the fix, thanks.
David, was this the bug that was causing the recent errors with the rebased
GCC port?
Cheers,
Edgar