[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches.
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches. |
Date: |
Sat, 03 Nov 2012 15:24:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 |
Il 03/11/2012 15:19, Paolo Bonzini ha scritto:
> Il 03/11/2012 12:50, Blue Swirl ha scritto:
>> I'm still getting problems with Clang on Linux:
>>
>> CC qemu-sockets.o
>> /src/qemu/qemu-sockets.c:64:12: error: function
>> 'default_monitor_get_fd' is not needed and will not be emitted
>> [-Werror,-Wunneeded-internal-declaration]
>> static int default_monitor_get_fd(Monitor *mon, const char *name, Error
>> **errp)
>> ^
>> /src/qemu/qemu-sockets.c:73:12: error: function
>> 'default_qemu_set_fd_handler2' is not needed and will not be emitted
>> [-Werror,-Wunneeded-internal-declaration]
>> static int default_qemu_set_fd_handler2(int fd,
>> ^
>> 2 errors generated.
>>
>> Perhaps the weak magic isn't so great after all.
>>
>
> It's a clang bug. The error should be suppressed, since the function is
> used with the weak alias.
>
> Or try if adding "|| defined __clang__" to compiler.h fixes it.
Other possible fixes include adding "inline" to the declarations, or of
course -Wno-unneeded-internal-declaration.
Paolo
- [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches., Paolo Bonzini, 2012/11/02
- [Qemu-devel] [PATCH v2 1/5] compiler: support Darwin weak references, Paolo Bonzini, 2012/11/02
- [Qemu-devel] [PATCH v2 2/5] semaphore: implement fallback counting semaphores with mutex+condvar, Paolo Bonzini, 2012/11/02
- [Qemu-devel] [PATCH v2 5/5] vl: delay thread initialization after daemonization, Paolo Bonzini, 2012/11/02
- [Qemu-devel] [PATCH v2 3/5] qemu-timer: reinitialize timers after fork, Paolo Bonzini, 2012/11/02
- [Qemu-devel] [PATCH v2 4/5] vl: unify calls to init_timer_alarm, Paolo Bonzini, 2012/11/02
- Re: [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches., Peter Maydell, 2012/11/02