Re: [Qemu-devel] [PATCH v4 0/7] TCG global variables clean-up

[Blue Swirl]

On Fri, Nov 2, 2012 at 5:06 AM, Evgeny Voevodin <address@hidden> wrote:
> On 10/31/2012 11:01 PM, Richard Henderson wrote:
>>
>> On 2012-10-31 16:19, Evgeny Voevodin wrote:
>>>
>>> Evgeny (2):
>>>    tcg/tcg.h: Duplicate global TCG variables in TCGContext
>>>    TCG: Remove unused global variables
>>>
>>> Evgeny Voevodin (5):
>>>    target-cris/translate.c: Code style clean-up
>>>    TCG: Use gen_opc_ptr from context instead of global variable.
>>>    TCG: Use gen_opparam_ptr from context instead of global variable.
>>>    TCG: Use gen_opc_buf from context instead of global variable.
>>>    TCG: Use gen_opparam_buf from context instead of global variable.
>>>
>>>   gen-icount.h                  |    2 +-
>>>   target-alpha/translate.c      |   10 +-
>>>   target-arm/translate.c        |   10 +-
>>>   target-cris/translate.c       | 5041
>>> +++++++++++++++++++++--------------------
>>>   target-i386/translate.c       |   10 +-
>>>   target-lm32/translate.c       |   13 +-
>>>   target-m68k/translate.c       |   10 +-
>>>   target-microblaze/translate.c |   13 +-
>>>   target-mips/translate.c       |   11 +-
>>>   target-openrisc/translate.c   |   13 +-
>>>   target-ppc/translate.c        |   11 +-
>>>   target-s390x/translate.c      |   11 +-
>>>   target-sh4/translate.c        |   10 +-
>>>   target-sparc/translate.c      |   10 +-
>>>   target-unicore32/translate.c  |   10 +-
>>>   target-xtensa/translate.c     |    8 +-
>>>   tcg/optimize.c                |   62 +-
>>>   tcg/tcg-op.h                  |  324 +--
>>>   tcg/tcg.c                     |   85 +-
>>>   tcg/tcg.h                     |   10 +-
>>>   translate-all.c               |    3 -
>>>   21 files changed, 2860 insertions(+), 2817 deletions(-)
>>
>> Reviewed-by: Richard Henderson <address@hidden>
>>
>>
>> r~
>>
>
>
> Thanks. Will anybody apply this?

I still can't apply the patches, stuck at 5/7:

Applying: TCG: Use gen_opc_buf from context instead of global variable.
error: patch failed: tcg/tcg.c:1359
error: tcg/tcg.c: patch does not apply
Patch failed at 0005 TCG: Use gen_opc_buf from context instead of
global variable.


>
>
> --
> Kind regards,
> Evgeny Voevodin,
> Technical Leader,
> Mobile Group,
> Samsung Moscow Research Center,
> e-mail: address@hidden
>