Re: [Qemu-devel] [PATCH 1/8] usb: Add packet combining functions

[Hans de Goede]

Hi,

On 11/01/2012 11:08 AM, Gerd Hoffmann wrote:
> On 10/31/12 13:47, Hans de Goede wrote:
> > +    /*
> > +     * If we had leftover packets the hcd driver will have cancelled them
> > +     * and usb_combined_packet_cancel has already freed combined!
> > +     */
> > +    if (state != leftover) {
> > +        g_free(combined);
> > +    }
>
> This calls for reference-counting USBCombinedPacket IMHO.

Here is a patch changing the way this is handled to something which
hopefully will be more to your liking. Feel free to squash this
into the original commit.

Regards,

Hans

0001-usb-combined-packet-Move-freeing-of-combined-to-usb_.patch
Description: Text Data