[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/7] target-alpha: Turn CPU definitions into sub
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 2/7] target-alpha: Turn CPU definitions into subclasses |
Date: |
Wed, 31 Oct 2012 15:57:43 +1100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 |
On 2012-10-31 14:03, Andreas Färber wrote:
> +static const AlphaCPUInfo alpha_cpus[] = {
> + { .name = "ev4", .initfn = ev4_cpu_initfn },
> + { .name = "ev5", .initfn = ev5_cpu_initfn },
> + { .name = "ev56", .initfn = ev56_cpu_initfn },
> + { .name = "pca56", .initfn = pca56_cpu_initfn },
> + { .name = "ev6", .initfn = ev6_cpu_initfn },
> + { .name = "ev67", .initfn = ev67_cpu_initfn },
> + { .name = "ev68", .initfn = ev68_cpu_initfn },
> + { .name = "21064", .initfn = alpha_21064_cpu_initfn },
> + { .name = "21164", .initfn = alpha_21164_cpu_initfn },
> + { .name = "21164a", .initfn = alpha_21164a_cpu_initfn },
> + { .name = "21164pc", .initfn = alpha_21164pc_cpu_initfn },
> + { .name = "21264", .initfn = alpha_21264_cpu_initfn },
> + { .name = "21264a", .initfn = alpha_21264a_cpu_initfn },
> +};
The "2*" names are aliases of the "ev*" names. There's no need for so
much duplication. And for that matter, "ev68" is no different from "ev67"
at the level for which we emulate. In hw, it was more cache and a faster
multiply implementation.
r~
- [Qemu-devel] [PATCH 0/7] target-alpha: More CPU QOM'ifications, Andreas Färber, 2012/10/30
- [Qemu-devel] [FYI 1/7] target-alpha: Use consistent include paths, Andreas Färber, 2012/10/30
- [Qemu-devel] [PATCH 3/7] target-alpha: Add support for -cpu ?, Andreas Färber, 2012/10/30
- [Qemu-devel] [PATCH 2/7] target-alpha: Turn CPU definitions into subclasses, Andreas Färber, 2012/10/30
- Re: [Qemu-devel] [PATCH 2/7] target-alpha: Turn CPU definitions into subclasses,
Richard Henderson <=
- [Qemu-devel] [PATCH 5/7] alpha: Pass AlphaCPU array to Typhoon, Andreas Färber, 2012/10/30
- [Qemu-devel] [PATCH 6/7] target-alpha: Avoid leaking the alarm timer over reset, Andreas Färber, 2012/10/30
- [Qemu-devel] [PATCH 4/7] target-alpha: Let cpu_alpha_init() return AlphaCPU, Andreas Färber, 2012/10/30
- [Qemu-devel] [RFC 7/7] target-alpha: Implement CPU reset, Andreas Färber, 2012/10/30