Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/2] Make default boot order machine specific

[David Gibson]

On Thu, Oct 25, 2012 at 09:50:10PM +0100, Peter Maydell wrote:
> On 25 October 2012 21:18, Anthony Liguori <address@hidden> wrote:
> > The other approach to this would be:
> >
> > static QEMUMachine pseries_machine = {
> >     .no_boot_order = 1,
> > };
> >
> > Which I think is what Peter is suggesting.  I'm not a huge fan of this
> > because it's backwards logic but we already do this for a bunch of other
> > things so I can't object too strongly to it.
> 
> The other issue is that "cad" is a load of rubbish for half of these
> boards, which don't have anything resembling the usual PC boot
> devices and probably don't pay attention to -boot anyway. A patch
> which only applied a boot order to boards which actually used it
> would probably also be rather shorter.

True, but I don't think it's reasonable to expect people other than
the maintainers of those boards to make that judgement.  The correct
approach is to keep the same behaviour for now, then let individual
boards change away from it.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson