[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/8] virtio-rng: hardware random number generato
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH 0/8] virtio-rng: hardware random number generator device |
Date: |
Fri, 26 Oct 2012 10:14:16 -0500 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Paolo Bonzini <address@hidden> writes:
> Il 26/10/2012 13:01, Amit Shah ha scritto:
>> Amit Shah (1):
>> virtio-rng: hardware random number generator device
>>
>> Anthony Liguori (7):
>> object: add object_property_add_bool (v2)
>> qdev: add realized property and make adding child bus implied by
>> realize
>> vl: add -object option to create QOM objects from the command line
>> vl: add -late-object to create QOM objects after machine init
>> rng: add RndBackend abstract object class
>> rng-urandom: add an RNG backend that uses /dev/urandom
>> rng-egd: introduce EGD compliant RNG backend
>
> Honestly I think this is overengineered.
>
> I would instead have the following:
>
> - a chardev that can read from a file (e.g. -chardev
> file,path=/dev/urandom,read=on,id=urandom)
Then your multiplexing lots of logic into the chardev layer.
Three of these patches can be dropped. See the series I sent out.
Regards,
Anthony Liguori
> - a device that accepts a chardev and understands both egd and raw
> (e.g.
> -device virtio-rng-pci,chardev=urandom,egd=off or -device
> virtio-rng-pci,chardev=egdsock,egd=on).
>
> - optionally, a chardev that can produce an endless stream of data via
> rdrand.
>
> And that's it.
>
> Also, even if RngBackend goes in, there is no need for -late-object
> right now, so I would not include it in this series.
>
> Paolo
- [Qemu-devel] [PATCH 0/8] virtio-rng: hardware random number generator device, Amit Shah, 2012/10/26
- [Qemu-devel] [PATCH 1/8] object: add object_property_add_bool (v2), Amit Shah, 2012/10/26
- [Qemu-devel] [PATCH 2/8] qdev: add realized property and make adding child bus implied by realize, Amit Shah, 2012/10/26
- [Qemu-devel] [PATCH 3/8] vl: add -object option to create QOM objects from the command line, Amit Shah, 2012/10/26
- [Qemu-devel] [PATCH 4/8] vl: add -late-object to create QOM objects after machine init, Amit Shah, 2012/10/26
- [Qemu-devel] [PATCH 5/8] rng: add RndBackend abstract object class, Amit Shah, 2012/10/26
- [Qemu-devel] [PATCH 6/8] rng-urandom: add an RNG backend that uses /dev/urandom, Amit Shah, 2012/10/26
- [Qemu-devel] [PATCH 7/8] rng-egd: introduce EGD compliant RNG backend, Amit Shah, 2012/10/26
- [Qemu-devel] [PATCH 8/8] virtio-rng: hardware random number generator device, Amit Shah, 2012/10/26
- Re: [Qemu-devel] [PATCH 0/8] virtio-rng: hardware random number generator device, Paolo Bonzini, 2012/10/26
- Re: [Qemu-devel] [PATCH 0/8] virtio-rng: hardware random number generator device,
Anthony Liguori <=