qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/4] qemu-char: Add new char backend CirMemCharD


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 1/4] qemu-char: Add new char backend CirMemCharDriver
Date: Thu, 25 Oct 2012 14:05:08 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1

On 10/25/2012 01:54 PM, Lei Li wrote:
> Signed-off-by: Lei Li <address@hidden>
> ---
>  qemu-char.c     |  136 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  qemu-config.c   |    3 +
>  qemu-options.hx |   10 ++++
>  3 files changed, 149 insertions(+), 0 deletions(-)
> 
>  
> +/*********************************************************/
> +/*CircularMemory chardev*/
> +

Better; I'll assume the other thread also title v5 was a mis-send.

> +Create a circular buffer with fixed size indicated by optionally 
> @option{maxcapacity}
> +which will be default 64K if it is not given.
> +
> address@hidden specify the max capacity of the size of circular buffer
> +want to create. Should be power of 2.

Still, this grammar could be improved:

s/specify/specifies/
s/want//

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]