Re: [Qemu-devel] [PATCH v1 4/8] usb/ehci: Add usb-ehci-sysbus

[Avi Kivity]

On 10/25/2012 11:55 AM, Peter Maydell wrote:
> On 25 October 2012 10:47, Peter Crosthwaite
> <address@hidden> wrote:
>> +static int usb_ehci_sysbus_initfn(SysBusDevice *dev)
>> +{
>> +    EHCIItfState *i = FROM_SYSBUS(EHCIItfState, dev);
>> +    EHCIState *s = &i->ehci;
>> +
>> +    s->dma = g_new(DMAContext, 1);
>> +    dma_context_init(s->dma, &address_space_memory, NULL, NULL, NULL);
> 
> Assuming Avi doesn't reject it, better to use the dma_context_memory
> I introduced in this patch (not yet applied to master):
>   http://patchwork.ozlabs.org/patch/193550/
> 

Patch is good, sorry if you were expecting an explicit ack.


-- 
error compiling committee.c: too many arguments to function