Re: [Qemu-devel] [PATCH v3 00/26] q35 qemu support

[Alexander Graf]

On 22.10.2012, at 16:03, Eric Blake wrote:

> On 10/22/2012 08:23 AM, Michael S. Tsirkin wrote:
>> On Mon, Oct 22, 2012 at 07:00:56AM -0600, Eric Blake wrote:
>>> On 10/22/2012 07:16 AM, Michael S. Tsirkin wrote:
>>> 
>>>> I worry about need to maintain  bug for bug compatibility on the
>>>> unlikely chance that the work to complete it gets delayed and we release
>>>> it in an unready state.
>>>> 
>>>>> But in any case this needs
>>>>> discussion with the libvirt folks to make sure it will actually work as
>>>>> intended.  /me tends to think a experimental bit in machine_info (which
>>>>> is then printed by 'qemu -M ?' and the QOM-version of that) is more
>>>>> useful than playing tricks with the name.
>>>>> 
>>>>> cheers,
>>>>>  Gerd
>>>> 
>>>> I agree it's best to ask libvirt folks what's the right way to hide
>>>> a machine type from it. Add a flag so it's not listed in -M ?  ?
>>> 
>>> For qemu 1.3, libvirt will NOT be reading '-M ?', but instead calling
>>> the 'query-machines' QMP command.  If you want a machine to be avoided
>>> by libvirt, then perhaps it is best to augment the MachineInfo QMP
>>> datatype to add an optional field that says whether a particular machine
>>> type is stable enough for libvirt's use.
>> 
>> Or just hide this machine type from the query-machines command?
> 
> That would probably work, as well.

You would still want the testing from users behind libvirt, so hiding is not 
good. Hiding by default with an experimental tag would probably be the best.


Alex