Re: [Qemu-devel] [PATCH v2 3/6] pflash_cfi0x: QOMified

[Peter Maydell]

On 22 October 2012 08:19, Peter Crosthwaite
<address@hidden> wrote:
> QOMified the pflash_cfi0x so machine models can connect them up in custom 
> ways.
>
> Kept the pflash_cfi0x_register functions as is. They can still be used to
> create a flash straight onto system memory.
>
> Signed-off-by: Peter Crosthwaite <address@hidden>

> --- a/hw/pflash_cfi01.c
> +++ b/hw/pflash_cfi01.c
> @@ -42,6 +42,7 @@
>  #include "qemu-timer.h"
>  #include "exec-memory.h"
>  #include "host-utils.h"
> +#include "sysbus.h"
>
>  #define PFLASH_BUG(fmt, ...) \
>  do { \
> @@ -60,21 +61,29 @@ do {                                               \
>  #endif
>
>  struct pflash_t {
> +    SysBusDevice busdev;
>      BlockDriverState *bs;
> -    target_phys_addr_t sector_len;
> -    int width;
> +    uint32_t nb_blocs;
> +    /* FIXME: get rid of target_phys_addr_t usage */

This comment is no longer necessary. If you delete it then
you can mark the next version as
Reviewed-by: Peter Maydell <address@hidden>

-- PMM