[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] e1000: Don't set the Capabilities List bit
From: |
Philipp Hahn |
Subject: |
Re: [Qemu-devel] [PATCH] e1000: Don't set the Capabilities List bit |
Date: |
Fri, 19 Oct 2012 13:02:43 +0200 |
User-agent: |
KMail/1.9.10 (enterprise35 20100903.1171286) |
Hello,
On Friday 19 October 2012 11:59:24 Philipp Hahn wrote:
> On Wednesday 21 September 2011 22:06:25 dann frazier wrote:
...
> > - /* TODO: we have no capabilities, so why is this bit set? */
> > - pci_set_word(pci_conf + PCI_STATUS, PCI_STATUS_CAP_LIST);
...
> Since cmask[PCI_STATUS=6] = PCI_STATUS_CAP_LIST=0x10 marks that bit as
> unmodifiable, the functions returns an error and aborts loading the saved
> state.
...
> Has somebody an idea how to fix this issue?
I'm no expert on PCI issues, but since e1000 drivers don't seem to much care
about the Capability List bit, perhaps the attached patch to ignore the bit
for e1000 would be in oder?
At least it fixes my problem.
Comments welcomed.
Sincerely
Philipp Hahn
--
Philipp Hahn Open Source Software Engineer address@hidden
Univention GmbH be open. fon: +49 421 22 232- 0
Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99
http://www.univention.de/
0003-Bug-24702-e1000-pci-config.patch
Description: Text Data
signature.asc
Description: This is a digitally signed message part.