Re: [Qemu-devel] [PATCHv4] tests/tcg: fix build

[Catalin Patulea]

On Tue, Oct 16, 2012 at 3:54 PM, Peter Maydell <address@hidden> wrote:
> This patch isn't in the right format to apply, I'm afraid.
> Major problem:
>  * missing signed-off-by line: we can't accept any patch
>    without one
> Minor problem:
>  * the actual commit message is below the first '---' line,
>    so 'git am' won't see it. Commit messages go above '---',
>    "what I changed in this version' notes below.
I saw this format (notes, commit message, diffstat) on another list
and assumed git am could handle this properly.

It just seems strange to write the note somewhere *below* the commit
message - the notes should be the first thing people read, and below
them is the complete proposed patch. Is there any way to achieve that?

Meanwhile, I'll reformat and resend the patch.