[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/4] block: in commit, determine base image f
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 2/4] block: in commit, determine base image from the top image |
|
Date: |
Tue, 16 Oct 2012 09:35:29 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0 |
On 10/16/2012 09:31 AM, Jeff Cody wrote:
>> Also, I raised another bug[1] about a bad error message regarding
>> top_bs, if the user passes a different spelling than the canonical name
>> of the active image. Is that worth fixing in this series, or is it okay
>> to leave it until you actually add support for committing the top image?
>>
>> [1] https://lists.gnu.org/archive/html/qemu-devel/2012-10/msg02067.html
>>
>
> Since this doesn't pose an actual issue now, I was planning on just
> addressing that with the stage-2 patches, since that will likely touch
> other related areas of the code anyway. If you have major heartburn
> over this, I'll change it now.
Nah, waiting is fine. As I said in the original bug report, it is only
a poor quality error message at the moment, and fixing it may be easier
once you have additional pieces in place for committing the active
image. I just wanted to make sure the report wasn't lost.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature