[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 27/45] qmp: add drive-mirror command
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 27/45] qmp: add drive-mirror command |
Date: |
Tue, 16 Oct 2012 08:39:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0 |
Il 15/10/2012 19:33, Kevin Wolf ha scritto:
>> > +
>> > + flags = bs->open_flags | BDRV_O_RDWR;
> The two questions from last time are still open:
>
> Jeff's patches are in now, so we can do a bdrv_reopen() to remove
> BDRV_O_RDWR again when completing the mirror job.
It's not a big change, so I'll add this to v3.
> The other thing was the throttling. It's not entirely clear to me what
> our conclusion was, but you suggested to remove it entirely from the
> mirror because I/O throttling on the target is equivalent.
Yes, that was because at the time you were suggesting to give the target
a name. In the end that had too many problems, so I left that part out
for after Markus finishes his refactoring.
Paolo