[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 02/13] qdev: split up header so it can be used in
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [RFC 02/13] qdev: split up header so it can be used in cpu.h |
Date: |
Tue, 16 Oct 2012 02:01:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120825 Thunderbird/15.0 |
Am 04.10.2012 21:15, schrieb Eduardo Habkost:
> From: Anthony Liguori <address@hidden>
>
> Header file dependency is a frickin' nightmare right now. cpu.h tends to get
> included in our 'include everything' header files but qdev also needs to
> include
> those headers mainly for qdev-properties since it knows about CharDriverState
> and friends.
>
> We can solve this for now by splitting out qdev.h along the same lines that we
> previously split the C file. Then cpu.h just needs to include qdev-core.h
>
> [ehabkost: re-add DEFINE_PROP_PCI_HOST_DEVADDR, that was removed on the
> original patch (by mistake, I guess)]
> [ehabkost: kill qdev_prop_set_vlan() declaration]
>
> Signed-off-by: Anthony Liguori <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
Generally I am still in favor of doing such a per-topic file split, in
whatever way exactly we proceed with CPU-as-a-device.
If this is supposed to go through my CPU queue then I would prefer to
move the [ehabkost: ...] lines chronologically between the Sobs fwiw.
What I would insist on is mentioning both new file names in the commit
message (qdev-core.h and qdev-properties.h iiuc) since the +++ stats are
ambiguous.
I spotted the following textual discrepancy:
> diff --git a/hw/qdev-core.h b/hw/qdev-core.h
> new file mode 100644
> index 0000000..ca205fc
> --- /dev/null
> +++ b/hw/qdev-core.h
[...]
> +/*
> + * This callback is used to create Open Firmware device path in accordance
> with
> + * OF spec http://forthworks.com/standards/of1275.pdf. Indicidual bus
> bindings
> + * can be found here http://playground.sun.com/1275/bindings/.
> + */
[...]
> diff --git a/hw/qdev.h b/hw/qdev.h
> index d699194..365b8d6 100644
> --- a/hw/qdev.h
> +++ b/hw/qdev.h
[...]
> - /*
> - * This callback is used to create Open Firmware device path in
> accordance
> - * with OF spec http://forthworks.com/standards/of1275.pdf. Individual
> bus
> - * bindings can be found at http://playground.sun.com/1275/bindings/.
> - */
[snip]
"Individual" became "Indicidual" and the comment seems misplaced, which
makes myself ask whether this split was not done safely via copy&paste?
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [RFC v2 00/13] include qdev core in *-user, make CPU child of DeviceState, Eduardo Habkost, 2012/10/04
- [Qemu-devel] [RFC 11/13] qdev: use full qdev.h include path on qdev*.c, Eduardo Habkost, 2012/10/04
- [Qemu-devel] [RFC 03/13] qapi-types.h doesn't really need to include qemu-common.h, Eduardo Habkost, 2012/10/04
- [Qemu-devel] [RFC 05/13] qdev: rename qdev.c to qdev-core.c, Eduardo Habkost, 2012/10/04
- [Qemu-devel] [RFC 09/13] qdev: move reset register/unregister code to qdev-system.c, Eduardo Habkost, 2012/10/04
- [Qemu-devel] [RFC 07/13] qdev: move vmstate handling to qdev-system.c, Eduardo Habkost, 2012/10/04
- [Qemu-devel] [RFC 01/13] qdev: kill bogus comment, Eduardo Habkost, 2012/10/04
- [Qemu-devel] [RFC 02/13] qdev: split up header so it can be used in cpu.h, Eduardo Habkost, 2012/10/04
- Re: [Qemu-devel] [RFC 02/13] qdev: split up header so it can be used in cpu.h,
Andreas Färber <=
- [Qemu-devel] [RFC 06/13] qdev-core: isolate vmstate handling into separate functions, Eduardo Habkost, 2012/10/04
- [Qemu-devel] [RFC 13/13] make CPU a child of DeviceState, Eduardo Habkost, 2012/10/04
- [Qemu-devel] [RFC 12/13] include core qdev code into *-user, too, Eduardo Habkost, 2012/10/04
- [Qemu-devel] [RFC 04/13] qdev: separate core from the code used only by qemu-system-*, Eduardo Habkost, 2012/10/04
- [Qemu-devel] [RFC 10/13] move qemu_irq typedef out of cpu-common.h, Eduardo Habkost, 2012/10/04
- [Qemu-devel] [RFC 08/13] qdev-core: isolate reset register/unregister code, Eduardo Habkost, 2012/10/04