Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support.

[Andreas Färber]

Am 15.10.2012 08:51, schrieb Lei Li:
> On 10/12/2012 08:39 PM, Gerd Hoffmann wrote:
>> +void qmp_chardev_del(const char *id, Error **errp)
>> +{
>> +    CharDriverState *chr;
>> +
>> +    chr = qemu_chr_find(id);
>> +    if (NULL == chr) {
>> +        error_setg(errp, "Chardev '%s' not found\n", id);
> 
> Maybe this should be replaced by QERR_ macros to keep
> compatibility since this one is listed in ErrorClass
> in the schema, like:
> 
> error_set(errp, QERR_DEVICE_NOT_FOUND, id);

No, error_setg() is the new replacement, QERR_* is deprecated.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg