[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/21] pci: pci capability must be in PCI spa
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/21] pci: pci capability must be in PCI space |
Date: |
Sat, 13 Oct 2012 08:29:28 +0000 |
On Tue, Oct 9, 2012 at 3:30 AM, Jason Baron <address@hidden> wrote:
> From: Isaku Yamahata <address@hidden>
>
> pci capability must be in PCI space.
> It can't lay in PCIe extended config space.
>
> Signed-off-by: Isaku Yamahata <address@hidden>
> Signed-off-by: Jason Baron <address@hidden>
> ---
> hw/pci.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/hw/pci.c b/hw/pci.c
> index f855cf3..85ebef6 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -1626,12 +1626,11 @@ PCIDevice *pci_create_simple(PCIBus *bus, int devfn,
> const char *name)
> return pci_create_simple_multifunction(bus, devfn, false, name);
> }
>
> -static int pci_find_space(PCIDevice *pdev, uint8_t size)
> +static uint8_t pci_find_space(PCIDevice *pdev, uint8_t size)
> {
> - int config_size = pci_config_size(pdev);
> int offset = PCI_CONFIG_HEADER_SIZE;
> int i;
> - for (i = PCI_CONFIG_HEADER_SIZE; i < config_size; ++i)
> + for (i = PCI_CONFIG_HEADER_SIZE; i < PCI_CONFIG_SPACE_SIZE; ++i)
Please add braces.
> if (pdev->used[i])
> offset = i + 1;
> else if (i - offset + 1 == size)
> --
> 1.7.1
>
- [Qemu-devel] [PATCH v2 00/21] q35 qemu support, Jason Baron, 2012/10/08
- [Qemu-devel] [PATCH v2 03/21] pci: pci capability must be in PCI space, Jason Baron, 2012/10/08
- [Qemu-devel] [PATCH v2 05/21] pc, pc_piix: split out pc nic initialization, Jason Baron, 2012/10/08
- [Qemu-devel] [PATCH v2 04/21] pci: introduce pci_swizzle_map_irq_fn() for standardized interrupt pin swizzle, Jason Baron, 2012/10/08
- [Qemu-devel] [PATCH v2 02/21] blockdev: Introduce IF_AHCI, Jason Baron, 2012/10/08
- [Qemu-devel] [PATCH v2 06/21] pc: Move ioapic_init() from pc_piix.c to pc.c, Jason Baron, 2012/10/08
- [Qemu-devel] [PATCH v2 01/21] blockdev: Introduce a default machine blockdev interface field, QEMUMachine->mach_if, Jason Baron, 2012/10/08