Re: [Qemu-devel] [PATCH 24/25] qmp: add NBD server commands

[Paolo Bonzini]

Il 10/10/2012 22:41, Eric Blake ha scritto:
> On 10/10/2012 08:03 AM, Paolo Bonzini wrote:
>> Adding an NBD server inside QEMU is trivial, since all the logic is
>> in nbd.c and can be shared easily between qemu-nbd and QEMU itself.
>> The main difference is that qemu-nbd serves a single unnamed export,
>> while QEMU serves named exports.
>>
>> Acked-by: Luiz Capitulino <address@hidden>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
> 
>> +##
>> +# @nbd-server-add:
>> +#
>> +# Export a device to QEMU's embedded NBD server.
>> +#
>> +# @device: Block device to be exported
>> +#
>> +# @writable: Whether clients should be able to write to the device via the
>> +#     NBD connection (default false). #optional
> 
> Isn't the #optional designation supposed to come first, before 'Whether'?

Does it really matter with no program yet written to consume it?
Putting it at the end matches the old qmp-commands.hx format better (for
commands that do have qmp-commands.hx documentation).

Paolo